Update stlSerializer.ts #9160
Merged
Update stlSerializer.ts #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaananW
reviewed
Oct 13, 2020
RaananW
approved these changes
Oct 13, 2020
Last minute changes.. Removed n vector3 negating & switched the input values as suggested. Updated default fileName to match binary mesh name (which is always 'stlmesh') Updated ASCII mesh name to match binary mesh name for consistency And removed fileName check in download code as it is defaulted at beginning.
|
Last minute changes, |
RaananW
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong orientation, flipped faces and bloated binary export.
-- Original mesh
-- After current export
-- After fixed export
